build-git-installers: decouple the VS registry settings from the autoupdater #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in #739, the VS registry settings are added only if the autoupdater feature is enabled. This was unintentional; Just like the corresponding part in the uninstaller, these two things should be apart. So let's decouple the VS registry settings from the autoupdater. Let's do that by ensuring that we put the function calls _outside_ of the autoupdater blocks. For good measure, we add checks to verify that both calls _were_ added, i.e. that the expected patterns were found. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #739, the VS registry settings are added only if the autoupdater feature is enabled. This was unintentional; Just like the corresponding part in the uninstaller, these two things should be apart.
So let's decouple the VS registry settings from the autoupdater.
Let's do that by ensuring that we put the function calls outside of the autoupdater blocks.
For good measure, we add checks to verify that both calls were added, i.e. that the expected patterns were found.
This fixes #739